Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rearrange doc test to shorten the testing time #975

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

YuanYuYuan
Copy link
Contributor

@YuanYuYuan YuanYuYuan commented Apr 25, 2024

The check job often finishes earlier than the test job. Move the doc test step to check can save us a few minutes.

@YuanYuYuan
Copy link
Contributor Author

@fuzzypixelz what do you think about this change?

@fuzzypixelz
Copy link
Member

@fuzzypixelz what do you think about this change?

Although a bit misleading since rustdoc tests are tests, I'm not against it. I'm all for a faster CI :) Maybe rename the name of first job to "Lints and documentation tests" and the name of the second job to "Unit tests".

@YuanYuYuan
Copy link
Contributor Author

@fuzzypixelz what do you think about this change?

Although a bit misleading since rustdoc tests are tests, I'm not against it. I'm all for a faster CI :) Maybe rename the name of first job to "Lints and documentation tests" and the name of the second job to "Unit tests".

That's a good suggestion. I'll add it.

@YuanYuYuan YuanYuYuan changed the title feat(ci): rearrange doc test to shorten the testing time ci: rearrange doc test to shorten the testing time Apr 25, 2024
@YuanYuYuan
Copy link
Contributor Author

YuanYuYuan commented Apr 25, 2024

Done. I shortened the name to "Lints and doc tests" so that the names of jobs can show completely on the web page.

@Mallets Mallets merged commit 7c64d99 into eclipse-zenoh:main Apr 25, 2024
11 checks passed
@Mallets Mallets deleted the feat/rearrange-doc-test branch April 25, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants